Changeset 1270

Timestamp:

09/27/07 22:43:24 (11 months ago)

Author:

calvin

Message:

a bunch of crash fixes when there are no patterns in the pattern editor, fix crash on delete in wave editor when there was no wave selected, spaces->tabs

Location:

trunk/src/buzelib

Files:

• PatternEditor/PatternEditorInner.cpp (modified) (2 diffs)
• PatternView.cpp (modified) (33 diffs)
• WaveEditorCtrl.cpp (modified) (14 diffs)
• WaveTableView.cpp (modified) (15 diffs)

trunk/src/buzelib/PatternEditor/PatternEditorInner.cpp

@@ -409 +409 @@
 
 LRESULT CPatternEditorInner::OnChar(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL& bHandled) {
+        if (cursor_columns.size() == 0) return 0;
+
         cursor_column& ccol = cursor_columns[cursor.x];
 
@@ -852 +854 @@
 
 void CPatternEditorInner::MoveCursor(int x, int y, bool affectsel) {
+        if (cursor_columns.size() == 0) return;
 
         POINT last_cursor = cursor;

trunk/src/buzelib/PatternView.cpp

@@ -54 +54 @@
 
 LRESULT CTwinCombo::OnSelChange(WORD wNotifyCode, WORD wID, HWND hWndCtl, BOOL& bHandled) {
-    GetParent().SendMessage(WM_COMMAND, MAKELONG(GetDlgCtrlID(), TWINCOMBO_SELCHANGE), (LPARAM)hWndCtl);
+        GetParent().SendMessage(WM_COMMAND, MAKELONG(GetDlgCtrlID(), TWINCOMBO_SELCHANGE), (LPARAM)hWndCtl);
         return 0;
 }
 
 LRESULT CTwinCombo::OnCloseUp(WORD wNotifyCode, WORD wID, HWND hWndCtl, BOOL& bHandled) {
-    GetParent().SendMessage(WM_COMMAND, MAKELONG(GetDlgCtrlID(), TWINCOMBO_CLOSEUP), (LPARAM)hWndCtl);
+        GetParent().SendMessage(WM_COMMAND, MAKELONG(GetDlgCtrlID(), TWINCOMBO_CLOSEUP), (LPARAM)hWndCtl);
         return 0;
 }
 
 LRESULT CTwinCombo::OnDropDown(WORD wNotifyCode, WORD wID, HWND hWndCtl, BOOL& bHandled) {
-    GetParent().SendMessage(WM_COMMAND, MAKELONG(GetDlgCtrlID(), TWINCOMBO_DROPDOWN), (LPARAM)hWndCtl);
+        GetParent().SendMessage(WM_COMMAND, MAKELONG(GetDlgCtrlID(), TWINCOMBO_DROPDOWN), (LPARAM)hWndCtl);
         return 0;
 }
 
 int CTwinCombo::GetComboIndex(HWND hWnd) {
-    if (combo1.m_hWnd == hWnd) return 0;
-    if (combo2.m_hWnd == hWnd) return 1;
-    return -1;
+        if (combo1.m_hWnd == hWnd) return 0;
+        if (combo2.m_hWnd == hWnd) return 1;
+        return -1;
 }
 
 int CTwinCombo::GetCurSel(int combo) {
-    CComboBox cc[] = { combo1, combo2 };
-    return cc[combo].GetCurSel();
+        CComboBox cc[] = { combo1, combo2 };
+        return cc[combo].GetCurSel();
 }
 
 int CTwinCombo::GetCount(int combo) {
-    CComboBox cc[] = { combo1, combo2 };
-    return cc[combo].GetCount();
+        CComboBox cc[] = { combo1, combo2 };
+        return cc[combo].GetCount();
 }
 
 void CTwinCombo::DeleteString(int combo, int index) {
-    CComboBox cc[] = { combo1, combo2 };
-    cc[combo].DeleteString(index);
+        CComboBox cc[] = { combo1, combo2 };
+        cc[combo].DeleteString(index);
 }
 
 void CTwinCombo::InsertString(int combo, int index, LPCSTR lpcstr) {
-    CComboBox cc[] = { combo1, combo2 };
-    cc[combo].InsertString(index, lpcstr);
+        CComboBox cc[] = { combo1, combo2 };
+        cc[combo].InsertString(index, lpcstr);
 }
 
 void CTwinCombo::SelectString(int combo, int index, LPCSTR lpcstr) {
-    CComboBox cc[] = { combo1, combo2 };
-    cc[combo].SelectString(index, lpcstr);
+        CComboBox cc[] = { combo1, combo2 };
+        cc[combo].SelectString(index, lpcstr);
 }
 
@@ -112 +112 @@
 
 CPatternView::CPatternView(CMainFrame* mainFrm, ClientViewListener* cvl)
-    :CViewImpl<CMainFrame, CDocument, CPatternView>(mainFrm->document)
+        :CViewImpl<CMainFrame, CDocument, CPatternView>(mainFrm->document)
         ,clientViewListener( cvl)
         ,mainFrame(mainFrm)
 {
-    pattern = document->getSelectedPattern();
-    machine = document->getSelectedPatternMachine();
+        pattern = document->getSelectedPattern();
+        machine = document->getSelectedPatternMachine();
 
         fromSequencerTrack=-1;
@@ -126 +126 @@
 
 CPatternView::~CPatternView(void) {
-    HIMAGELIST hImageList = (HIMAGELIST)::SendMessage(hWndButtonToolBar, TB_SETIMAGELIST, 0, 0);
-    ImageList_Destroy(hImageList);
-
-    if (m_hWnd)
-        DestroyWindow();
+        HIMAGELIST hImageList = (HIMAGELIST)::SendMessage(hWndButtonToolBar, TB_SETIMAGELIST, 0, 0);
+        ImageList_Destroy(hImageList);
+
+        if (m_hWnd)
+                DestroyWindow();
 }
 
@@ -230 +230 @@
 
 LRESULT CPatternView::OnClose(UINT /*uMsg*/, WPARAM /*wParam*/, LPARAM /*lParam*/, BOOL& /*bHandled*/) {
-    setPattern(0,0); // in case pattern is deleted and window updated before window is fully destroyed
+        setPattern(0,0); // in case pattern is deleted and window updated before window is fully destroyed
 
         CMessageLoop* pLoop = _Module.GetMessageLoop();
@@ -237 +237 @@
         pLoop->RemoveMessageFilter(this);
 
-    document->removeView(this);
+        document->removeView(this);
         mainFrame->removeTimerHandler(this);
         mainFrame->removeTabableView(m_hWnd);
@@ -249 +249 @@
         GetClientRect(&rc);
         patternEditor.MoveWindow(0, getToolbarHeight(), rc.right, rc.bottom - getToolbarHeight() - 20);
-    statusBar.MoveWindow(0, rc.bottom - 20, rc.right, 20);
-
-    RECT rcItem;
-    getBandRect(waveDropDown, &rcItem);
-    waveDropDown.MoveWindow(rcItem.left, rcItem.top, rcItem.right-rcItem.left, rcItem.bottom-rcItem.top + 200);
-
-    getBandRect(octaveDropDown, &rcItem);
-    octaveDropDown.MoveWindow(rcItem.left, rcItem.top, rcItem.right-rcItem.left, rcItem.bottom-rcItem.top + 200);
-
-    getBandRect(stepDropDown, &rcItem);
-    stepDropDown.MoveWindow(rcItem.left, rcItem.top, rcItem.right-rcItem.left, rcItem.bottom-rcItem.top + 200);
+        statusBar.MoveWindow(0, rc.bottom - 20, rc.right, 20);
+
+        RECT rcItem;
+        getBandRect(waveDropDown, &rcItem);
+        waveDropDown.MoveWindow(rcItem.left, rcItem.top, rcItem.right-rcItem.left, rcItem.bottom-rcItem.top + 200);
+
+        getBandRect(octaveDropDown, &rcItem);
+        octaveDropDown.MoveWindow(rcItem.left, rcItem.top, rcItem.right-rcItem.left, rcItem.bottom-rcItem.top + 200);
+
+        getBandRect(stepDropDown, &rcItem);
+        stepDropDown.MoveWindow(rcItem.left, rcItem.top, rcItem.right-rcItem.left, rcItem.bottom-rcItem.top + 200);
 
         return 0;
@@ -271 +271 @@
 LRESULT CPatternView::OnFocus(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL& bHandled) {
         mainFrame->setCurrentFocus(m_hWnd);
-    patternEditor.SetFocus();
+        patternEditor.SetFocus();
 
         document->selectPattern(machine, pattern);
-    return 0;
+        return 0;
 }
 
@@ -299 +299 @@
 LRESULT CPatternView::OnDelete(WORD /*wNotifyCode*/, WORD /*wID*/, HWND /*hWndCtl*/, BOOL& bHandled) {
 
-    if (pattern == 0) return 0;
+        if (pattern == 0) return 0;
 
         if (patternEditor.HasSelection() && !document->configuration->getStickySelections()) {
                 deletePatternSelection();
         } else {
-        pattern_position pos = document->getPatternPosition(machine, pattern);
+                pattern_position pos = document->getPatternPosition(machine, pattern);
                 document->deleteRow(machine, pattern, pos.group, pos.track, -1, pos.row);
         }
@@ -311 +311 @@
 
 LRESULT CPatternView::OnSelectAll(WORD /*wNotifyCode*/, WORD /*wID*/, HWND /*hWndCtl*/, BOOL& bHandled) {
+        if (pattern == 0) return 0;
+
         patternEditor.SelectRange(0, 0, patternEditor.GetColumns() - 1, pattern->getRows() - 1);
         return 0;
@@ -316 +318 @@
 
 LRESULT CPatternView::OnClearSelection(WORD /*wNotifyCode*/, WORD /*wID*/, HWND /*hWndCtl*/, BOOL& bHandled) {
+        if (pattern == 0) return 0;
+
         patternEditor.SelectRange(-1, -1, -1, -1);
         return 0;
@@ -321 +325 @@
 
 LRESULT CPatternView::OnViewProperties(WORD /*wNotifyCode*/, WORD /*wID*/, HWND /*hWndCtl*/, BOOL& bHandled) {
-    if (pattern == 0) return 0;
-
-    document->selectedPropertyProvider = new CPatternPropertyProvider(*this, document, machine, pattern);
-    document->updateAllViews(0, UpdateProperties);
+        if (pattern == 0) return 0;
+
+        document->selectedPropertyProvider = new CPatternPropertyProvider(*this, document, machine, pattern);
+        document->updateAllViews(0, UpdateProperties);
         return 0;
 }
 
 LRESULT CPatternView::OnOctaveSelChange(WORD wNotifyCode, WORD wID, HWND hWndCtl, BOOL& bHandled) {
-    int sel = octaveDropDown.GetCurSel();
-    if (sel == -1) return 0;
-    char pc[32];
-    octaveDropDown.GetLBText(sel, pc);
-    patternEditor.SetOctave(atoi(pc));
-    return 0;
+        int sel = octaveDropDown.GetCurSel();
+        if (sel == -1) return 0;
+        char pc[32];
+        octaveDropDown.GetLBText(sel, pc);
+        patternEditor.SetOctave(atoi(pc));
+        return 0;
 }
 
 LRESULT CPatternView::OnStepSelChange(WORD wNotifyCode, WORD wID, HWND hWndCtl, BOOL& bHandled) {
-    int sel = stepDropDown.GetCurSel();
-    if (sel == -1) return 0;
-    char pc[32];
-    stepDropDown.GetLBText(sel, pc);
-    patternEditor.editor.step = atoi(pc);
-    return 0;
+        int sel = stepDropDown.GetCurSel();
+        if (sel == -1) return 0;
+        char pc[32];
+        stepDropDown.GetLBText(sel, pc);
+        patternEditor.editor.step = atoi(pc);
+        return 0;
 }
 
 LRESULT CPatternView::OnPatternClone(WORD /*wNotifyCode*/, WORD /*wID*/, HWND /*hWndCtl*/, BOOL& /*bHandled*/) {
-    if (pattern == 0) return 0;
-
-    document->clonePattern(machine, pattern);
+        if (pattern == 0) return 0;
+
+        document->clonePattern(machine, pattern);
 
         zzub::pattern* clonedPattern = machine->getPattern(machine->getPatterns()-1);
@@ -358 +362 @@
 
 LRESULT CPatternView::OnMachineAddTrack(WORD /*wNotifyCode*/, WORD /*wID*/, HWND /*hWndCtl*/, BOOL& /*bHandled*/) {
+        if (machine == 0) return 0;
         document->addPatternTrack(machine);
         mainFrame->SetFocus();  // this line is here because utrk changes focus in buze only
@@ -364 +369 @@
 
 LRESULT CPatternView::OnMachineRemoveTrack(WORD /*wNotifyCode*/, WORD /*wID*/, HWND /*hWndCtl*/, BOOL& /*bHandled*/) {
+        if (machine == 0) return 0;
+
         document->removePatternTrack(machine);
         mainFrame->SetFocus();  // this line is here because utrk changes focus in buze only
@@ -370 +377 @@
 
 LRESULT CPatternView::OnPatternPlay(WORD /*wNotifyCode*/, WORD /*wID*/, HWND /*hWndCtl*/, BOOL& /*bHandled*/) {
-    if (pattern == 0) return 0;
-
-        
-    document->playPattern(machine, pattern);
+        if (pattern == 0) return 0;
+        document->playPattern(machine, pattern);
         return 0;
 }
 
 LRESULT CPatternView::OnPatternPlayFromCursor(WORD /*wNotifyCode*/, WORD /*wID*/, HWND /*hWndCtl*/, BOOL& /*bHandled*/) {
-    if (pattern == 0) return 0;
+        if (pattern == 0) return 0;
 
         pattern_position pos = document->getPatternPosition(machine, pattern);
-    document->playPattern(machine, pattern, pos.row);
+        document->playPattern(machine, pattern, pos.row);
         return 0;
 }
@@ -392 +397 @@
 
 LRESULT CPatternView::OnPatternDelete(WORD /*wNotifyCode*/, WORD /*wID*/, HWND /*hWndCtl*/, BOOL& /*bHandled*/) {
-    if (pattern == 0) return 0;
-
-    document->deletePattern(machine, pattern);
+        if (pattern == 0) return 0;
+        document->deletePattern(machine, pattern);
         return 0;
 }
 
 LRESULT CPatternView::OnPatternDoubleRows(WORD /*wNotifyCode*/, WORD /*wID*/, HWND /*hWndCtl*/, BOOL& /*bHandled*/) {
-    if (pattern == 0) return 0;
+        if (pattern == 0) return 0;
         document->doublePatternRows(machine, pattern);
         return 0;
@@ -406 +410 @@
 // test 010
 LRESULT CPatternView::OnPatternDoubleLength(WORD /*wNotifyCode*/, WORD /*wID*/, HWND /*hWndCtl*/, BOOL& /*bHandled*/) {
-    if (pattern == 0) return 0;
+        if (pattern == 0) return 0;
         document->setPatternLength(machine, pattern, pattern->getRows() * 2);
         return 0;
@@ -413 +417 @@
 
 LRESULT CPatternView::OnPatternHalveRows(WORD /*wNotifyCode*/, WORD /*wID*/, HWND /*hWndCtl*/, BOOL& /*bHandled*/) {
-    if (pattern == 0) return 0;
+        if (pattern == 0) return 0;
         document->halvePatternRows(machine, pattern);
         return 0;
@@ -419 +423 @@
 
 LRESULT CPatternView::OnSelChangeScale(WORD /*wNotifyCode*/, WORD /*wID*/, HWND /*hWndCtl*/, BOOL& /*bHandled*/) {
-    int sel = scaleDropDown.GetCurSel();
-    if (sel == -1) return 0;
-    patternEditor.SetSkip(sel+1);
+        int sel = scaleDropDown.GetCurSel();
+        if (sel == -1) return 0;
+        patternEditor.SetSkip(sel+1);
         return 0;
 }
 
 LRESULT CPatternView::OnSelChangeBeat(WORD /*wNotifyCode*/, WORD /*wID*/, HWND /*hWndCtl*/, BOOL& /*bHandled*/) {
-    int sel = beatDropDown.GetCurSel();
-    if (sel == -1) return 0;
+        int sel = beatDropDown.GetCurSel();
+        if (sel == -1) return 0;
 //    patternEditor.beat = sel;
         patternEditor.Invalidate();
@@ -434 +438 @@
 
 void CPatternView::OnUpdate(CView* pSender, LPARAM lHint, LPVOID pHint) {
-    zzub::metaplugin* updatePlugin = 0;
-    zzub::pattern* updatePattern = 0;
-    PatternEditorMode mode = (PatternEditorMode)_Module.configuration->getPatternMode();
-
-    if (machine == 0 && pattern == 0) return ;
-
-    switch (lHint) {
+        zzub::metaplugin* updatePlugin = 0;
+        zzub::pattern* updatePattern = 0;
+        PatternEditorMode mode = (PatternEditorMode)_Module.configuration->getPatternMode();
+
+        if (machine == 0 && pattern == 0) return ;
+
+        switch (lHint) {
                 case UpdatePatternScroll:
-            updatePattern = (zzub::pattern*)pHint;
-            if (updatePattern == pattern) {
+                        updatePattern = (zzub::pattern*)pHint;
+                        if (updatePattern == pattern) {
                                 //patternEditor.Invalidate();
-                //patternEditor.UpdateCaret();
-            }
+                                //patternEditor.UpdateCaret();
+                        }
                         break;
-        case UpdatePatternPosition:
-            updatePattern = (zzub::pattern*)pHint;
-            if (updatePattern == pattern) {
-                patternEditor.ScrollToView();
-                //patternEditor.invalidateCursor();
-                bindStatus();
-            }
-            break;
-        case UpdateSelectedPattern:
-            updatePattern = (zzub::pattern*)pHint;
-            if (updatePattern == 0 || updatePattern == pattern) {
-                //patternEditor.Invalidate();
+                case UpdatePatternPosition:
+                        updatePattern = (zzub::pattern*)pHint;
+                        if (updatePattern == pattern) {
+                                patternEditor.ScrollToView();
+                                //patternEditor.invalidateCursor();
+                                bindStatus();
+                        }
+                        break;
+                case UpdateSelectedPattern:
+                        updatePattern = (zzub::pattern*)pHint;
+                        if (updatePattern == 0 || updatePattern == pattern) {
+                                //patternEditor.Invalidate();
                                 patternEditor.editor.Invalidate();
-                patternEditor.UpdateCaret();
-            }
-            break;
-        case UpdateSelectedMachine:
-            updatePlugin = (metaplugin*)pHint;
-            if (updatePlugin == machine) {
-                bindPatternEditor();
-                patternEditor.ScrollToView();
-                patternEditor.UpdateScrollbars();
-                patternEditor.UpdateCaret();
+                                patternEditor.UpdateCaret();
+                        }
+                        break;
+                case UpdateSelectedMachine:
+                        updatePlugin = (metaplugin*)pHint;
+                        if (updatePlugin == machine) {
+                                bindPatternEditor();
+                                patternEditor.ScrollToView();
+                                patternEditor.UpdateScrollbars();
+                                patternEditor.UpdateCaret();
                                 patternEditor.Invalidate(FALSE);
                                 patternEditor.editor.Invalidate(FALSE);
-                bindMachinePatternPanel();
-            }
-            break;
-        case UpdateDeletePattern:
-            updatePattern = (zzub::pattern*)pHint;
-            if (updatePattern == pattern) {
-                if (mode == OneEditorOverall || mode == OneEditorPerMachine) {
-                    // move to next pattern if it exists
-                    size_t patternIndex = machine->getPatternIndex(pattern);
-                    zzub::pattern* nextPattern = 0;
-                    if (patternIndex < machine->getPatterns() -1)
-                        nextPattern = machine->getPattern(patternIndex + 1); else
-                    if (patternIndex > 0)
-                        nextPattern = machine->getPattern(patternIndex - 1); else
-                        nextPattern = 0;
-
-                    setPattern(machine, nextPattern);
-                } else {
-                    mainFrame->clientViewHide(m_hWnd);
-                }
-            }
-            break;
-        case UpdateDeleteMachine:
-            updatePlugin = (metaplugin*)pHint;
-            if (updatePlugin == machine) {
-                if (mode == OneEditorOverall) {
-                    setPattern(0, 0);
-                } else {
-                    mainFrame->clientViewHide(m_hWnd);
-                }
-            }
-            break;
-        /*case UpdateEditPattern:
-            //patternEditor.UpdateScrollbars();
-            //patternEditor.UpdateCaret();
-            bindStatus();
-            break;*/
-        case UpdatePattern:
-        case UpdateMachines:
-            bindMachinePatternPanel();
-            break;
-        case UpdateTheme:
-            patternEditor.UpdateWindow();
+                                bindMachinePatternPanel();
+                        }
                         break;
-        case UpdatePatternSelection:
-            patternEditor.UpdateWindow();
-            bindStatus();
-            break;
+                case UpdateDeletePattern:
+                        updatePattern = (zzub::pattern*)pHint;
+                        if (updatePattern == pattern) {
+                                if (mode == OneEditorOverall || mode == OneEditorPerMachine) {
+                                        // move to next pattern if it exists
+                                        size_t patternIndex = machine->getPatternIndex(pattern);
+                                        zzub::pattern* nextPattern = 0;
+                                        if (patternIndex < machine->getPatterns() -1)
+                                                nextPattern = machine->getPattern(patternIndex + 1); else
+                                        if (patternIndex > 0)
+                                                nextPattern = machine->getPattern(patternIndex - 1); else
+                                                nextPattern = 0;
+
+                                        setPattern(machine, nextPattern);
+                                } else {
+                                        mainFrame->clientViewHide(m_hWnd);
+                                }
+                        }
+                        break;
+                case UpdateDeleteMachine:
+                        updatePlugin = (metaplugin*)pHint;
+                        if (updatePlugin == machine) {
+                                if (mode == OneEditorOverall) {
+                                        setPattern(0, 0);
+                                } else {
+                                        mainFrame->clientViewHide(m_hWnd);
+                                }
+                        }
+                        break;
+                /*case UpdateEditPattern:
+                        //patternEditor.UpdateScrollbars();
+                        //patternEditor.UpdateCaret();
+                        bindStatus();
+                        break;*/
+                case UpdatePattern:
+                case UpdateMachines:
+                        bindMachinePatternPanel();
+                        break;
+                case UpdateTheme:
+                        patternEditor.UpdateWindow();
+                        break;
+                case UpdatePatternSelection:
+                        patternEditor.UpdateWindow();
+                        bindStatus();
+                        break;
                 case UpdateImportWave:
                 case UpdateClearWave:
@@ -535 +539 @@
                         break;
                 }
-    }
-    // set dirty flags based on hint and invalidate if anything needs redrawing
+        }
+        // set dirty flags based on hint and invalidate if anything needs redrawing
 }
 
 LRESULT CPatternView::OnMachinePatternSelChange(WORD wNotifyCode, WORD wID, HWND hWndCtl, BOOL& bHandled) {
-    int changedCombo = machinePatternPanel.GetComboIndex(hWndCtl);
-    if (changedCombo == -1) return 0;
+        int changedCombo = machinePatternPanel.GetComboIndex(hWndCtl);
+        if (changedCombo == -1) return 0;
 
         int machineIndex = machinePatternPanel.GetCurSel(0);
         int patternIndex = 0;
-    if (changedCombo == 1) 
-        patternIndex = machinePatternPanel.GetCurSel(1);
-
-    if (machineIndex == -1) return 0;
+        if (changedCombo == 1) 
+                patternIndex = machinePatternPanel.GetCurSel(1);
+
+        if (machineIndex == -1) return 0;
 
         CHAR machineName[1024];
@@ -558 +562 @@
 
         mainFrame->showPatternEditor(pattern, machine);
-    return 0;
+        return 0;
 }
 
@@ -759 +763 @@
         metaplugin* tempmac = document->player->getMachine(machineName);
         if (tempmac) 
-        mainFrame->showPatternEditor(tempmac->getPattern(0), tempmac);
-    return 0;
+                mainFrame->showPatternEditor(tempmac->getPattern(0), tempmac);
+        return 0;
 
 }
@@ -770 +774 @@
         metaplugin* tempmac = document->player->getMachine(machineName);//index-1);
         if (tempmac) 
-        mainFrame->showPatternEditor(tempmac->getPattern(0), tempmac);
-    return 0;
+                mainFrame->showPatternEditor(tempmac->getPattern(0), tempmac);
+        return 0;
 }
 
 
 void CPatternView::transposeSelection(int delta) {
+        if (pattern == 0) return ;
+
         patterntrack* selection = createSelection();
         if (!selection) {
@@ -874 +880 @@
 
 LRESULT CPatternView::OnInterpolateSelection(WORD wNotifyCode, WORD wID, HWND hWndCtl, BOOL& bHandled) {
+        if (pattern == 0) return 0;
+
         patterntrack* selection = createSelection();
         if (!selection) return 0;
@@ -896 +904 @@
 
 LRESULT CPatternView::OnRandomizeSelection(WORD wNotifyCode, WORD wID, HWND hWndCtl, BOOL& bHandled) {
+        if (pattern == 0) return 0;
+
         patterntrack* selection = createSelection();
         if (!selection) {
@@ -943 +953 @@
 
 LRESULT CPatternView::OnClearEntry(WORD wNotifyCode, WORD wID, HWND hWndCtl, BOOL& bHandled) {
+        if (pattern == 0) return 0;
 
         patternEditor.Clear();
@@ -967 +978 @@
 
 LRESULT CPatternView::OnSoloMachine(WORD wNotifyCode, WORD wID, HWND hWndCtl, BOOL& bHandled) {
+        if (machine == 0) return 0;
+
         if (document->player->getSoloMachine()==machine)
                 document->setMachineSolo(machine, FALSE); else
@@ -974 +987 @@
 
 LRESULT CPatternVie